Skip to content

[css-text-decor-4] Renamed text-decoration-trim to text-decoration-inset #13039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[css-text-decor-4] Renamed text-decoration-trim to text-decoration-inset #13039

wants to merge 4 commits into from

Conversation

@SebastianZ
Copy link
Contributor

@SebastianZ SebastianZ commented Oct 29, 2025

According to the resolution from #8402 (comment).

See also #13024 for the part of the {row|column}-rule-* properties.

Sebastian

@jfkthame
Copy link
Contributor

jfkthame commented Oct 29, 2025

There are also a number of mentions of "trim" in the description of the auto value that should be reworded, I think.

(While you're there, perhaps also fix the long-obsolete mention of text-decoration-skip-inset in the caption of the Chinese auto illustration.)

@SebastianZ SebastianZ force-pushed the text-decoration-inset branch 2 times, most recently from 0212def to 52c94b2 Compare October 29, 2025 22:55
@SebastianZ
Copy link
Contributor Author

SebastianZ commented Oct 29, 2025

There are also a number of mentions of "trim" in the description of the auto value that should be reworded, I think.

Replaced that by "length adjustments".

(While you're there, perhaps also fix the long-obsolete mention of text-decoration-skip-inset in the caption of the Chinese auto illustration.)

I renamed them all to text-decoration-inset now.

It seems we also had a text-decoration-skip-inset longhand for the text-decoration-skip shorthand at some point. As it seems it got replaced by text-decoration-inset at some point, I've now removed the remnants of the other property. That also means, text-decoration-inset is not a longhand for text-decoration-skip anymore.

Sebastian

@SebastianZ SebastianZ requested a review from jfkthame November 2, 2025 21:55
fantasai
fantasai reviewed Nov 5, 2025
View reviewed changes
css-text-decor-4/Overview.bs Outdated
</dl>

Text decoration trimming is subject to 'box-decoration-break':
The adjustment of the text decoration's length is subject to 'box-decoration-break':
Copy link
Collaborator

@fantasai fantasai Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not adjusting the length, we're adjusting the start and endpoints. It could keep the length constant, for example if it were specified as -2px 2px. Open to other ideas, but I think keeping with the "trimming" terminology is clearer here, even if the name of the property has changed. "Length adjustment" is not precise enough.

Copy link
Contributor Author

@SebastianZ SebastianZ Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I tried to adust the wording. Let me know if it's better now!

@SebastianZ SebastianZ force-pushed the text-decoration-inset branch from 2dc5f21 to 3a9f6fc Compare November 6, 2025 00:42
@chrisdavidmills chrisdavidmills mentioned this pull request Nov 6, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fantasai fantasai fantasai left review comments

@kojiishi kojiishi Awaiting requested review from kojiishi

@jfkthame jfkthame Awaiting requested review from jfkthame

Assignees

No one assigned

Labels

css-text-decor-4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SebastianZ @jfkthame @fantasai